Subject: Re: FVWM: CurrentScreen patch for fvwm 2.0.43

From: Dan Niles <[email-masked]>
Date: Wed, 10 Jul 1996 11:04:28 -0500

> 
> Well, I just added your patch to 2.1.0, slightly modified to match
> what I thought made the most sense:
> 
>   CurrentDesk - As expected
>   CurrentPage - This page, this desk
>   SamePage    - Same page XY, but any desk
> 
> and I left CurrentScreen as a synonym for SamePage (current behavior)
> but I plan to remove CurrentScreen from the man page.  But perhaps a
> better name for SamePage would be CurrentPageAnyDesk?  It may be long,
> but I like explict names like that, so I think I'll change it to that
> (CurrentPageAnyDesk) if no one comes up with a better one.
> 
> Chuck
> 

Having CurrentPage and SamePage could be confusing.  Having CurrentPage
and CurrentPageAnyDesk makes it fairly clear what each one does.

I think CurrentPageAnyDesk is a good name.  It is long, but it will 
probably not be used that often.

Here is the patch with the new names so people will not have to wait
until 2.1.0 comes out.

------------------------- fvwm-2.0.43-CurrentPage.patch -----------------------
--- builtins.c.orig	Tue Jul  9 11:16:15 1996
+++ builtins.c	Wed Jul 10 10:59:19 1996
@@ -1794,7 +1794,7 @@
   Bool needsIconic = 0;
   Bool needsNormal = 0;
   Bool needsCurrentDesk = 0;
-  Bool needsCurrentScreen = 0;
+  Bool needsCurrentPage = 0;
   Bool needsVisible = 0;
   Bool needsInvisible = 0;
   char *AnyWindow = "*";
@@ -1843,8 +1843,14 @@
         needsVisible = 1;
       else if(mystrcasecmp(condition,"!Visible")==0)
         needsInvisible = 1;
-      else if(mystrcasecmp(condition,"CurrentScreen")==0)
-        needsCurrentScreen = 1;
+      else if(mystrcasecmp(condition,"CurrentPage")==0)
+	{
+	  needsCurrentDesk = 1;
+	  needsCurrentPage = 1;
+	}
+      else if((mystrcasecmp(condition,"CurrentPageAnyDesk")==0)
+      	     || (mystrcasecmp(condition,"CurrentScreen")==0))
+        needsCurrentPage = 1;
       else if(mystrcasecmp(condition,"CirculateHit")==0)
         useCirculateHit = 1;
       else if(mystrcasecmp(condition,"CirculateHitIcon")==0)
@@ -1898,7 +1904,7 @@
            ((!needsCurrentDesk)||(fw->Desk == Scr.CurrentDesk))&&
            ((!needsVisible)||(fw->flags & VISIBLE))&&
            ((!needsInvisible)||(!(fw->flags & VISIBLE)))&&
-           ((!needsCurrentScreen)||((fw->frame_x < Scr.MyDisplayWidth)&&
+           ((!needsCurrentPage)||((fw->frame_x < Scr.MyDisplayWidth)&&
                                     (fw->frame_y < Scr.MyDisplayHeight)&&
                                     (fw->frame_x+fw->frame_width > 0)&&
                                     (fw->frame_y+fw->frame_height > 0)))))
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to [email-masked].
To report problems, send mail to [email-masked].