Subject: FVWM: Small bug in bitmap search path of fvwm-2.0.40/41.

From: [email-masked]
Date: Tue, 20 Feb 1996 10:33:54 +0100 (MET)

Hi,

I think there is a small bug in the search algorithm of fvwm-2.0.40 and
fvwm-2.0.41.  According to the man-page, the IconPath is the search path for
bitmaps, while the PixmapPath is for pixmaps.  Of course, the latter only
makes sense when compiled with XPM.  My guess is that fvwm should search both
paths when compiled with XPM.  However, it doesn't.  It *only* searches
searches the PixmapPath.  The following patch fixes this.

*** Picture.c	Mon Nov  6 17:36:25 1995
--- Picture.c.new	Wed Jan  3 12:52:22 1996
***************
*** 46,53 ****
  #ifdef XPM

!   path = findIconFile(name, PixmapPath,R_OK);
!   if(path == NULL)return;  
  
    XGetWindowAttributes(dpy,Root,&root_attr);
    xpm_attributes.colormap = root_attr.colormap;
--- 46,54 ----
  #ifdef XPM

!   if ((path = findIconFile(name, PixmapPath,R_OK)) == NULL
!       && (path = findIconFile(name, IconPath,R_OK)) == NULL)
!     return;
  
    XGetWindowAttributes(dpy,Root,&root_attr);
    xpm_attributes.colormap = root_attr.colormap;

Greetings,

Pieter

--

Pieter Vosbeek                                    E-mail: [email-masked]
Department of Mechanical Engineering                    Phone: +31 40 247 28 27
Eindhoven University of Technology                        Fax: +31 40 244 73 55
P.O. Box 513, 5600 MB Eindhoven, The Netherlands         Home: +31 77 472 12 02
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to [email-masked].
To report problems, send mail to [email-masked].