Subject: Re: Event tables are inconsistent and broken

From: Albrecht Kadlec <[email-masked]>
Date: 18 Aug 1999 20:43:18 +0200

[email-masked] writes:

> Full_Name: Mark Rawling
> Version: 2.2.2
> CVS_Date: 
> OS: SunOS 5.5.1
> X_Server: Openwindows
> Submission from: (NULL) (216.70.156.58)
> 
> 
> The event spec tables in FvwmEvent.c and FvwmAudio.c are
> inconsistent, nor do they agree with fvwm/module.h
> The event tables in FvwmEvent.c and FvwmAudio.c are not initialised
> correctly. The FvwmEvent table has some ifdefs in it, which, if not defined

these were for events added in 2.0.46 IIRC

the table definition is bad, as the builtins follow the other events.
so each time a new event surfaces they're relocated.
The ifdefs were to cleanly compile under various 2.0.xx versions.

> screw up the location of the inbuilts. The result is that startup audio
> sounds don't play - it uses the unknown sound instead. This can be fixed
> by
> putting
> 
> else
>       "",
> endif

or removing these IFDEFS alltogether.
those days have long passed.

> into the table twice where the ifdefs are. But even then these
> tables disagree with the event definitions in module.h. The tables have 
> no equivalents for LOCKONSEND and SENDCONFIG. 28 is the correct number but

these didn't exist back then ....

-- 
Albrecht Kadlec
Vienna University of Technology / Department of Automation
----------------------------------------------------------
There cannot be a crisis today; my schedule is already full.
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [email-masked].
To report problems, send mail to [email-masked]