Subject: Real Bug fix for FvwmWinList.c - 2.0.47b.

From: Rocky - Rakesh Patel <[email-masked]>
Date: Wed, 1 Jul 1998 15:57:37 -0400 (EDT)

I have to aplogize for posting inadequately tested patches for the
geometry "hop" that occurs with the FvwmWinList when items are added and
deleted.

Serious testing revealed the real problem and here is a diff just to fix
this one bug and I'd like to see the bug fix at least integrated into
the full release:

*** FvwmWinList.c.ORIG	Mon Jan 26 16:02:46 1998
--- FvwmWinList.c	Wed Jul  1 15:42:59 1998
***************
*** 720,729 ****
--- 720,733 ----
      {
        if (win_grav==SouthEastGravity || win_grav==NorthEastGravity)
          win_x-=(new_width-win_width);
+       if ( win_border > 0) win_x+=win_border+1;
  
        if (win_grav==SouthEastGravity || win_grav==SouthWestGravity)
          win_y-=(new_height-win_height);
+       if ( win_border > 0) win_y+=win_border+1;
  
+       XMoveResizeWindow(dpy,win,win_x,
+ 			win_y, new_width,new_height);
  #if 0
        if(RESIZE_BUG_HACK)
        {
***************
*** 748,756 ****
  	else	
  		win_y-=win_border;
  #endif /* 0 */
- 
-       XMoveResizeWindow(dpy,win,win_x+win_border,win_y+win_title+win_border,
-         new_width,new_height);
  
      }
      else
--- 752,757 ----

                             Rakesh B. Patel
                         [email-masked]
                           Network Operations
                       Telecommunications Division
              Rutgers University Computing Services (RUCS)
                             +1 732-445-3436

Love is an ocean of emotions, entirely surrounded by expenses.
				-Thomas Robert Dewar
But it's worth it.
	- Rakesh Patel
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [email-masked].
To report problems, send mail to [email-masked].

---

From: Brady Montz <[email-masked]>
Date: 02 Jul 1998 10:11:30 -0700

> geometry "hop" that occurs with the FvwmWinList when items are added and

The patch failed, perhaps because of an earlier version of the patch. Anyhow, 
Here's what this section of FvwmWinList.c now looks like:

  if (WindowIsUp && (new_height!=win_height  || new_width!=win_width))
  {
    if (Anchor)
    {
      if (win_grav==SouthEastGravity || win_grav==NorthEastGravity)
        win_x-=(new_width-win_width);
      if ( win_border > 0) win_x+=win_border+1;

      if (win_grav==SouthEastGravity || win_grav==SouthWestGravity)
        win_y-=(new_height-win_height);
      if ( win_border > 0) win_y+=win_border+1; 

      XMoveResizeWindow(dpy, win, win_x, win_y, new_width, new_height);

#if 0
      if(RESIZE_BUG_HACK)
      {
		win_x+= win_border - 2;
	else
		win_x-=win_border;

	if (win_grav==SouthEastGravity || win_grav==SouthWestGravity)
		win_y+=win_border - 2;
	else	
		win_y-=win_border;
      }
#else /* ckh - need to come up w/ better way to calculate win_x & _y */
        if (win_grav==SouthEastGravity || win_grav==NorthEastGravity)
		win_x+= win_border-3;
	else
		win_x-=win_border;

		win_y+=win_border-3;
	else	
		win_y-=win_border;
#endif /* 0 */

    }
    else
      XResizeWindow(dpy, win, new_width,new_height);

    XSync(dpy,False);
  }

This doesn't seem to work at all. Every time my xterm title changes, the
window moves upwards (Using *FvwmWinListGeometry -0-1).

-- 
 Brady Montz
 [email-masked]