Subject: Mini icons and title bars

From: Bjorn Victor <[email-masked]>
Date: Thu, 17 Apr 97 10:29:50 +0200

Hello, I hope this is the right forum for bug reports and patches for
Fvwm 2.0.45?  Anyway, here's two bug reports, one with a fix and one
without:

PROBLEM 1:
 WindowList and FvwmIconMan don't display Mini Icons for some windows.
DIAGNOSIS:
 These windows don't have title bars.  Fvwm doesn't read mini icons
 for windows without title bars.
SOLUTION:
 Patch AddWindow in add_window.c by moving the code that checks for
 and perhaps reads a mini icon to outside the conditional for the TITLE
 flag. 
NOTE:
 To make FvwmIconMan display mini icons on a black-and-white
 display, you need to patch it too.
PATCH:
*** add_window.c.~1~	Wed Jan 22 16:46:54 1997
--- add_window.c	Thu Apr 17 08:52:30 1997
***************
*** 532,537 ****
--- 532,539 ----
  	    tmp_win->right_w[i] = None;
  	}
        
+     }
+ 
  #ifdef MINI_ICONS
        if (tmp_win->mini_pixmap_file) {
  	tmp_win->mini_icon = CachePicture (dpy, Scr.Root, 
***************
*** 547,553 ****
  	tmp_win->mini_icon = NULL;
        }
  #endif
-     }
  
    if(tmp_win->flags & BORDER)
      {
--- 549,554 ----

PROBLEM 2:
 Title bars on windows without focus come out transparent on a
 black-and-white display under some circumstances.  Try Iconify on an
 iconified window without focus, and which doesn't get focus by Iconify.
DIAGNOSIS:
 This seems hairy, and I haven't had time to debug it completely.
WORK-AROUND:
 In SetBorder in borders.c, change the initialization of NewColor to
 True.  This fixes the problem with the title bars of non-sticky
 windows, but doesn't for sticky windows, and causes some update flaw
 for borders.
HELP:
 Yes please!

-- Bjorn Victor			[email-masked]
Dept. of Computer Systems	tel: +46 18 183169
Uppsala University		fax: +46 18 550225
Box 325				GSM: +46 70 7755768
S-751 05 Uppsala, SWEDEN
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [email-masked].
To report problems, send mail to [email-masked].